Issue 4823054: code review 4823054: container/vector: removed some uses of container/vector...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4823054: code review 4823054: container/vector: removed some uses of container/vector...

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by skelterjohn

Modified:
13 years, 7 months ago

Reviewers:
gri

CC:
gri, golang-dev

Visibility:
Public.

Description

container/vector: removed some uses of container/vector in other pkgs

Patch Set 1 #

Patch Set 2 : diff -r f69402f7beb7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f69402f7beb7 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -32 lines)			Patch
M	src/pkg/crypto/x509/x509.go	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download
M	src/pkg/http/request.go	View	1 2	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/pkg/json/decode.go	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
M	src/pkg/net/dict/dict.go	View	1	4 chunks	+3 lines, -4 lines	0 comments	Download
M	src/pkg/net/textproto/reader.go	View	1	4 chunks	+3 lines, -6 lines	0 comments	Download
M	src/pkg/websocket/client.go	View	1	2 chunks	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

skelterjohn

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-27 20:37:58 UTC) #1

skelterjohn

Hello gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 7 months ago (2011-07-27 20:41:07 UTC) #2

gri

13 years, 7 months ago (2011-07-27 22:23:46 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=5fa47694f2c5 ***

container/vector: removed some uses of container/vector in other pkgs

R=gri
CC=golang-dev
http://codereview.appspot.com/4823054

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages