Issue 4817058: code review 4817058: runtime: fix data race in findfunc()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4817058: code review 4817058: runtime: fix data race in findfunc() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by dvyukov

Modified:
13 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: fix data race in findfunc() The data race can lead to reads of partially initialized concurrently mutated symbol data. The change also adds a simple sanity test for Caller() and FuncForPC().

Patch Set 1 #

Patch Set 2 : diff -r c0e0030f5308 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c0e0030f5308 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c0e0030f5308 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9c32561a8704 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -2 lines)			Patch
M	src/pkg/runtime/386/asm.s	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/amd64/asm.s	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/arm/atomic.c	View	1 2 3 4	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/symtab.c	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
A	src/pkg/runtime/symtab_test.go	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-29 11:50:40 UTC) #1

dvyukov

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 7 months ago (2011-07-29 17:32:51 UTC) #3

rsc

13 years, 7 months ago (2011-07-29 17:47:38 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b6211e148237 ***

runtime: fix data race in findfunc()
The data race can lead to reads of partially
initialized concurrently mutated symbol data.
The change also adds a simple sanity test
for Caller() and FuncForPC().

R=rsc
CC=golang-dev
http://codereview.appspot.com/4817058

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages