Issue 4815063: code review 4815063: cgo: add GoBytes, fix gmp example

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4815063: code review 4815063: cgo: add GoBytes, fix gmp example (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

cgo: add GoBytes, fix gmp example Fixes issue 1640. Fixes issue 2007.

Patch Set 2 : diff -r f69402f7beb7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f69402f7beb7 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 570ed6f818c4 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 570ed6f818c4 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -4 lines)			Patch
M	misc/cgo/gmp/gmp.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	misc/cgo/stdio/file.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/cgo/ast.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/doc.go	View	1 2 3 4	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	1 2	5 chunks	+13 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/string.goc	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-27 17:46:19 UTC) #1

adg

LGTM http://codereview.appspot.com/4815063/diff/3001/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): http://codereview.appspot.com/4815063/diff/3001/src/cmd/cgo/doc.go#newcode78 src/cmd/cgo/doc.go:78: func C.GoBytes(unsafe.Pointer, C.int) []byte - C pointer, length ...

13 years, 7 months ago (2011-07-27 17:56:55 UTC) #2

rsc

13 years, 7 months ago (2011-07-28 16:39:55 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e3cd47e9748d ***

cgo: add GoBytes, fix gmp example

Fixes issue 1640.
Fixes issue 2007.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4815063

Expand All Messages | Collapse All Messages