code review 4815061: image/tiff: Do not panic when RowsPerStrip is missing.

src/pkg/image/tiff/reader_test.go

 // Copyright 2011 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package tiff
 
 import (
         "os"
         "testing"
 )
 
-// This test tries to decode an image that has no RowsPerStrip tag.

[nigeltao, 2011/07/27 02:22:07]

s/This test/TestNoRPS/.

[bsiegert, 2011/07/27 18:55:12]

Done.

+// TestNoRPS tries to decode an image that has no RowsPerStrip tag.
 // The tag is mandatory according to the spec but some software omits
 // it in the case of a single strip.
 func TestNoRPS(t *testing.T) {
-        f, err := os.Open("testdata/rps0.tiff")

[nigeltao, 2011/07/27 02:22:07]

If the func is called TestNoRPS, then call the test image
"testdata/no_rps.tiff".

[bsiegert, 2011/07/27 18:55:12]

Done.

+        f, err := os.Open("testdata/no_rps.tiff")
         if err != nil {
-                t.Errorf(err.String())

[nigeltao, 2011/07/27 02:22:07]

t.Error(err)
return

Same below.

[bsiegert, 2011/07/27 18:55:12]

Done; I used t.Fatal(err) instead.

+                t.Fatal(err)
         }
         defer f.Close()
         _, err = Decode(f)
         if err != nil {
-                t.Errorf(err.String())
+                t.Fatal(err)
         }
 }