Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1872)

Issue 4814061: code review 4814061: [release-branch.r59] gc: fix closure bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by adg
Modified:
9 years, 7 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

[release-branch.r59] gc: fix closure bug ««« CL 4709042 / d30305e2898a gc: fix closure bug Fixes issue 2056. R=rsc CC=golang-dev http://codereview.appspot.com/4709042 »»»

Patch Set 1 #

Patch Set 2 : diff -r 76eea63f0f27 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 04f56c184b6e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -38 lines) Patch
M src/cmd/gc/closure.c View 1 6 chunks +40 lines, -36 lines 0 comments Download
M src/cmd/gc/walk.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
A test/fixedbugs/bug346.go View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 7 months ago (2011-07-31 21:49:23 UTC) #1
r
LGTM asssuming it compiles and passes tests in the branch
9 years, 7 months ago (2011-07-31 21:57:36 UTC) #2
adg
On 31 July 2011 14:57, <r@golang.org> wrote: > LGTM > asssuming it compiles and passes ...
9 years, 7 months ago (2011-07-31 22:03:20 UTC) #3
adg
9 years, 7 months ago (2011-07-31 22:37:05 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=d5785050f61d ***

[release-branch.r59] gc: fix closure bug

««« CL 4709042 / d30305e2898a
gc: fix closure bug

Fixes issue 2056.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4709042
»»»

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4814061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b