code review 4814056: build: fix for noclobber users

build: fix for noclobber users

Fixes issue 2020.

[rsc, 2011-07-27 18:36:37]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-07-27 18:40:48]

LGTM

On Wed, Jul 27, 2011 at 11:36 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> build: fix for noclobber users
>
> Fixes issue 2020.
>
> Please review this at
http://codereview.appspot.com/**4814056/<http://codereview.appspot.com/4814056/>
>
> Affected files:
>  M src/env.bash
>
>
> Index: src/env.bash
> ==============================**==============================**=======
> --- a/src/env.bash
> +++ b/src/env.bash
> @@ -88,6 +88,11 @@
>        exit 1
>  fi
>
> +# Issue 2020: some users configure bash to default to
> +#      set +o noclobber
> +# which makes >x fail if x already exists.  Restore sanity.
> +set -o noclobber
> +
>  # Tried to use . <($MAKE ...) here, but it cannot set environment
>  # variables in the version of bash that ships with OS X.  Amazing.
>  eval $($MAKE --no-print-directory -f Make.inc go-env | egrep
> 'GOARCH|GOOS|GOHOSTARCH|**GOHOSTOS|GO_ENV')
>
>
>

[rsc, 2011-07-27 21:38:48]

*** Submitted as http://code.google.com/p/go/source/detail?r=85e8d39fb7bf ***

build: fix for noclobber users

Fixes issue 2020.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4814056