Issue 4813052: code review 4813052: 5g, 6g, 8g: shift, opt fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4813052: code review 4813052: 5g, 6g, 8g: shift, opt fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

5g, 6g, 8g: shift, opt fixes Fixes issue 1808.

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -41 lines)			Patch
M	src/cmd/5g/cgen64.c	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/5g/ggen.c	View	1	3 chunks	+40 lines, -12 lines	0 comments	Download
M	src/cmd/5g/gsubr.c	View	1 2	7 chunks	+6 lines, -1 line	0 comments	Download
M	src/cmd/5g/peep.c	View	1 2	3 chunks	+4 lines, -1 line	0 comments	Download
M	src/cmd/5g/reg.c	View	1 2	8 chunks	+6 lines, -11 lines	0 comments	Download
M	src/cmd/6g/gsubr.c	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	src/cmd/8g/gg.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/8g/ggen.c	View	1 2	3 chunks	+24 lines, -6 lines	0 comments	Download
M	src/cmd/8g/reg.c	View	1	3 chunks	+2 lines, -4 lines	0 comments	Download
M	src/cmd/gc/bits.c	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
A	test/fixedbugs/bug356.go	View	1 2	1 chunk	+41 lines, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-28 22:22:05 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=a5dffbdae6cf *** 5g, 6g, 8g: shift, opt fixes Fixes issue 1808. R=ken2 ...

13 years, 7 months ago (2011-07-28 22:22:25 UTC) #2

lgtm