Issue 4812053: code review 4812053: ld: detect all import cycles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4812053: code review 4812053: ld: detect all import cycles (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by rsc

Modified:
12 years, 9 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

ld: detect all import cycles Fixes issue 2052.

Patch Set 1 #

Patch Set 2 : diff -r b23c59e6b442 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b23c59e6b442 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b2bdccd98b04 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -1 line)			Patch
M	src/cmd/ld/go.c	View	1	3 chunks	+160 lines, -1 line	0 comments	Download
M	src/cmd/ld/lib.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2011-07-23 00:40:27 UTC) #1

rsc

12 years, 9 months ago (2011-07-23 01:18:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=abe33ce478e1 ***

ld: detect all import cycles

Fixes issue 2052.

R=r
CC=golang-dev
http://codereview.appspot.com/4812053

Expand All Messages | Collapse All Messages