Issue 4810057: code review 4810057: gc: diagnose (x) := 0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4810057: code review 4810057: gc: diagnose (x) := 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

gc: diagnose (x) := 0 Fixes issue 1756.

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -2 lines)			Patch
M	src/cmd/gc/dcl.c	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/go.y	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/cmd/gc/print.c	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	test/fixedbugs/bug351.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-27 21:39:30 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=2d3f0621450a *** gc: diagnose (x) := 0 Fixes issue 1756. R=ken2 CC=golang-dev ...

13 years, 7 months ago (2011-07-27 21:39:46 UTC) #2

lgtm