Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3369)

Issue 48090043: Add docs for setting up ES and Nagios

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by benji
Modified:
10 years, 3 months ago
Reviewers:
rharding, mp+200546, benji-york
Visibility:
Public.

Description

Add docs for setting up ES and Nagios Also fixed a branch URL in the docs that was no longer valid. https://code.launchpad.net/~benji/charmworld/elasticsearch-docs/+merge/200546 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A docs/configuring-nagios.rst View 1 chunk +13 lines, -0 lines 0 comments Download
M docs/deploy.rst View 1 chunk +1 line, -1 line 0 comments Download
A docs/rebuild-elasticsearch.rst View 1 chunk +25 lines, -0 lines 4 comments Download

Messages

Total messages: 3
benji
Please take a look.
10 years, 3 months ago (2014-01-06 15:31:58 UTC) #1
rharding
LGTM with a couple of comments. https://codereview.appspot.com/48090043/diff/1/docs/rebuild-elasticsearch.rst File docs/rebuild-elasticsearch.rst (right): https://codereview.appspot.com/48090043/diff/1/docs/rebuild-elasticsearch.rst#newcode15 docs/rebuild-elasticsearch.rst:15: $ /etc/init.d/elasticsearch start ...
10 years, 3 months ago (2014-01-06 15:42:29 UTC) #2
benji-york
10 years, 3 months ago (2014-01-06 15:46:26 UTC) #3
Good additions.  Thanks for the review.

https://codereview.appspot.com/48090043/diff/1/docs/rebuild-elasticsearch.rst
File docs/rebuild-elasticsearch.rst (right):

https://codereview.appspot.com/48090043/diff/1/docs/rebuild-elasticsearch.rst...
docs/rebuild-elasticsearch.rst:15: $ /etc/init.d/elasticsearch start
On 2014/01/06 15:42:29, rharding wrote:
> should we mention cleaning up any older versions here? I'm not sure if the ES
> machines are monitored for disk usage, but might be worth a mention that if
> we're resetting, any older ones can go away now. 

Good idea; done.

https://codereview.appspot.com/48090043/diff/1/docs/rebuild-elasticsearch.rst...
docs/rebuild-elasticsearch.rst:24: a set of enqueue/ingest jobs to run.  Once
run, the ES database will be
On 2014/01/06 15:42:29, rharding wrote:
> mention watching this from /heartbeat?

Sounds good; done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b