code review 4808089: exp/template/html: New package with a toy template tran...

src/pkg/exp/template/html/reverse_test.go

 // Copyright 2011 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package html
 
 import (
         "bytes"
         "exp/template"
         "testing"
 )
 
 type data struct {
         World  string
         Coming bool
 }
 
 func TestReverse(t *testing.T) {
         templateSource :=
                 "{{if .Coming}}Hello{{else}}Goodbye{{end}}, {{.World}}!"
         templateData := data{
                 World:  "Cincinatti",
                 Coming: true,
         }
 
         tmpl := template.New("test")
         tmpl, err := tmpl.Parse(templateSource)
         if err != nil {
-                t.Errorf("Failed to parse template: %s", err)

[r, 2011/08/11 03:57:17]

no initial caps in error strings. they're not sentences, really

[MikeSamuel, 2011/08/11 06:17:04]

Done in 3 places.

+                t.Errorf("failed to parse template: %s", err)
                 return
         }
 
         Reverse(tmpl)
 
-        buffer := bytes.NewBuffer(make([]byte, 0, 1024))
+        buffer := new(bytes.Buffer)
 
         err = tmpl.Execute(buffer, templateData)
         if err != nil {
-                t.Errorf("Failed to execute reversed template: %s", err)
+                t.Errorf("failed to execute reversed template: %s", err)
                 return
         }
 
         golden := "!ittanicniC ,olleH"
         actual := buffer.String()
         if golden != actual {
-                t.Errorf("Reversed output: %s != %s", golden, actual)

[r, 2011/08/11 03:57:17]

s/%s/%q/g

[MikeSamuel, 2011/08/11 06:17:04]

Done.  Is the difference between %s and %q analagous to the difference between
Stringer and GoStringer?

+                t.Errorf("reversed output: %q != %q", golden, actual)
         }
 }