Issue 4808057: code review 4808057: gc: another width test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4808057: code review 4808057: gc: another width test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
ken3, aam

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: another width test

Patch Set 1 #

Patch Set 2 : diff -r f69402f7beb7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 013db22d6889 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	A	test/fixedbugs/bug361.go	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-28 16:32:43 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=570ed6f818c4 *** gc: another width test R=ken2 CC=golang-dev http://codereview.appspot.com/4808057

13 years, 7 months ago (2011-07-28 16:32:51 UTC) #2

aam

Russ, this also fixes issue 713, as far as I can test. andrey On Thu, ...

13 years, 7 months ago (2011-07-28 16:47:51 UTC) #3

rsc

On Thu, Jul 28, 2011 at 12:47, andrey mirtchovski <mirtchovski@gmail.com> wrote: > Russ, this also ...

13 years, 7 months ago (2011-07-28 17:01:07 UTC) #4

lgtm

Expand All Messages | Collapse All Messages