Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(696)

Issue 4801042: code review 4801042: weekly.2011-07-19 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by adg
Modified:
10 years, 3 months ago
Reviewers:
CC:
golang-dev, nigeltao, dsymonds, r
Visibility:
Public.

Description

weekly.2011-07-19

Patch Set 1 #

Total comments: 8

Patch Set 2 : diff -r 5a834cedd347 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r 5a834cedd347 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 9
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 3 months ago (2011-07-20 05:18:15 UTC) #1
nigeltao
LGTM. On 20 July 2011 15:18, <adg@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: > ...
10 years, 3 months ago (2011-07-20 05:22:39 UTC) #2
dsymonds
LGTM http://codereview.appspot.com/4801042/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/4801042/diff/1/doc/devel/weekly.html#newcode82 doc/devel/weekly.html:82: * fmt: Scan(&int) was mishandling a lone zero. ...
10 years, 3 months ago (2011-07-20 05:26:55 UTC) #3
adg
Forgot to update this list since I started it last night. Please hold.
10 years, 3 months ago (2011-07-20 05:27:17 UTC) #4
r
http://codereview.appspot.com/4801042/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/4801042/diff/1/doc/devel/weekly.html#newcode20 doc/devel/weekly.html:20: This weekly snapshot includes a change to the image ...
10 years, 3 months ago (2011-07-20 05:35:38 UTC) #5
adg
http://codereview.appspot.com/4801042/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/4801042/diff/1/doc/devel/weekly.html#newcode20 doc/devel/weekly.html:20: This weekly snapshot includes a change to the image ...
10 years, 3 months ago (2011-07-20 05:37:52 UTC) #6
adg
Hello golang-dev@googlegroups.com, nigeltao@golang.org, dsymonds@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 3 months ago (2011-07-20 05:38:12 UTC) #7
r
LGTM http://codereview.appspot.com/4801042/diff/8001/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/4801042/diff/8001/doc/devel/weekly.html#newcode20 doc/devel/weekly.html:20: This weekly snapshot includes a a language change ...
10 years, 3 months ago (2011-07-20 05:42:30 UTC) #8
adg
10 years, 3 months ago (2011-07-20 05:46:04 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=3c21f37b25a3 ***

weekly.2011-07-19

R=golang-dev, nigeltao, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/4801042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b