Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 4798056: code review 4798056: gc: shift type bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by rsc
Modified:
13 years, 7 months ago
Reviewers:
ken2, ken3
CC:
golang-dev
Visibility:
Public.

Description

gc: shift type bug Fixes issue 1664.

Patch Set 1 #

Patch Set 2 : diff -r da40ff8d788e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 355408efced2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M src/cmd/gc/const.c View 1 1 chunk +18 lines, -2 lines 0 comments Download
A test/fixedbugs/bug363.go View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-07-28 17:03:29 UTC) #1
rsc
submitted but mercurial is unhappy.
13 years, 7 months ago (2011-07-28 17:05:46 UTC) #2
ken3
13 years, 7 months ago (2011-07-29 07:50:03 UTC) #3
lgtm
i have shift nightmares.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b