Issue 4798054: Change Maven groupId to com.google.oauth-client & some minor release fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4798054: Change Maven groupId to com.google.oauth-client & some minor release fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by yanivi

Modified:
14 years, 4 months ago

Reviewers:
jasonhall

CC:
aiuto, moshenko, rmistry

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -67 lines)			Patch
M	google-oauth-client-assembly/assembly.xml	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	google-oauth-client-assembly/pom.xml	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	google-oauth-client-extensions/pom.xml	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	google-oauth-client/pom.xml	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	jdiff.xml	View	2 chunks	+4 lines, -14 lines	0 comments	Download
M	pom.xml	View	3 chunks	+6 lines, -6 lines	2 comments	Download
M	release.html	View	11 chunks	+33 lines, -35 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jasonhall

LGTM http://codereview.appspot.com/4798054/diff/1/pom.xml File pom.xml (right): http://codereview.appspot.com/4798054/diff/1/pom.xml#newcode23 pom.xml:23: <inceptionYear>2011</inceptionYear> Actually, Inception came out in 2010. http://www.imdb.com/title/tt1375666/ ...

14 years, 4 months ago (2011-07-25 20:59:59 UTC) #2

yanivi

14 years, 4 months ago (2011-07-26 12:30:05 UTC) #3

http://codereview.appspot.com/4798054/diff/1/pom.xml
File pom.xml (right):

http://codereview.appspot.com/4798054/diff/1/pom.xml#newcode23
pom.xml:23: <inceptionYear>2011</inceptionYear>
On 2011/07/25 21:00:00, jasonhall wrote:
> Actually, Inception came out in 2010. http://www.imdb.com/title/tt1375666/
> 
> :)

:)

Expand All Messages | Collapse All Messages