Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Unified Diff: src/cmd/6l/asm.c

Issue 4794046: code review 4794046: ld: fix freebsd build reverting .interp move (Closed)
Patch Set: diff -r 8f4c6113ed2d https://go.googlecode.com/hg/ Created 13 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/cmd/5l/asm.c ('k') | src/cmd/8l/asm.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cmd/6l/asm.c
===================================================================
--- a/src/cmd/6l/asm.c
+++ b/src/cmd/6l/asm.c
@@ -591,22 +591,6 @@
elfstr[ElfStrGnuVersion] = addstring(shstrtab, ".gnu.version");
elfstr[ElfStrGnuVersionR] = addstring(shstrtab, ".gnu.version_r");
- /* interpreter string */
- if(interpreter == nil) {
- switch(HEADTYPE) {
- case Hlinux:
- interpreter = linuxdynld;
- break;
- case Hfreebsd:
- interpreter = freebsddynld;
- break;
- }
- }
- s = lookup(".interp", 0);
- s->type = SELFROSECT;
- s->reachable = 1;
- addstring(s, interpreter);
-
/* dynamic symbol table - first entry all zeros */
s = lookup(".dynsym", 0);
s->type = SELFROSECT;
@@ -909,7 +893,7 @@
break;
}
}
- shsym(sh, lookup(".interp", 0));
+ elfinterp(sh, startva, interpreter);
ph = newElfPhdr();
ph->type = PT_INTERP;
@@ -1088,7 +1072,7 @@
a += elfwritephdrs();
a += elfwriteshdrs();
cflush();
- if(a > ELFRESERVE)
+ if(a+elfwriteinterp() > ELFRESERVE)
diag("ELFRESERVE too small: %d > %d", a, ELFRESERVE);
break;
case Hwindows:
« no previous file with comments | « src/cmd/5l/asm.c ('k') | src/cmd/8l/asm.c » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b