Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 47660043: Add error handling of beginRecording (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Xianzhu
Modified:
12 years, 1 month ago
Reviewers:
dsinclair, nduca
CC:
trace-viewer-review_googlegroups.com
Base URL:
http://trace-viewer.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add error handling of beginRecording - End recording when the chrome://tracing window is closed or reloaded, otherwise we can't start tracing again. - Handle '##ERROR##' from /json/categories and /json/begin_recording requests (required a C++ side change). This will popup an error box if tracing is started from the second chrome://tracing window while the first chrome://tracing window is tracing. BUG=chromium:331286 R=nduca@chromium.org Committed: https://code.google.com/p/trace-viewer/source/detail?r=1084

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/about_tracing/begin_recording.js View 4 chunks +11 lines, -3 lines 1 comment Download

Messages

Total messages: 5
Xianzhu
12 years, 1 month ago (2014-01-03 23:04:27 UTC) #1
Xianzhu
https://codereview.appspot.com/47660043/diff/1/src/about_tracing/begin_recording.js File src/about_tracing/begin_recording.js (left): https://codereview.appspot.com/47660043/diff/1/src/about_tracing/begin_recording.js#oldcode24 src/about_tracing/begin_recording.js:24: resolver.reject(new Error('At ' + path + ' error ' ...
12 years, 1 month ago (2014-01-03 23:05:05 UTC) #2
nduca
lgtm
12 years, 1 month ago (2014-01-03 23:16:29 UTC) #3
Xianzhu
Committed patchset #1 manually as r1084 (presubmit successful).
12 years, 1 month ago (2014-01-03 23:23:30 UTC) #4
Xianzhu
12 years, 1 month ago (2014-01-04 00:08:09 UTC) #5
Message was sent while issue was closed.
The chromium side change also needs an approval:
https://codereview.chromium.org/117323008/.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b