Issue 4750047: code review 4750047: godoc: implement http.FileSystem for zip files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4750047: code review 4750047: godoc: implement http.FileSystem for zip files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by gri

Modified:
13 years, 4 months ago

Reviewers:

CC:
rsc, adg, bradfitz, golang-dev

Visibility:
Public.

Description

godoc: implement http.FileSystem for zip files

Patch Set 1 #

Patch Set 2 : diff -r d787393025dc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d787393025dc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d787393025dc https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r d787393025dc https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 85ab018b6c97 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+254 lines, -37 lines)			Patch
M	lib/godoc/dirlist.html	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/cmd/godoc/Makefile	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/godoc/filesystem.go	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/cmd/godoc/godoc.go	View	1	4 chunks	+30 lines, -18 lines	0 comments	Download
A	src/cmd/godoc/httpzip.go	View	1 2 3 4	1 chunk	+184 lines, -0 lines	0 comments	Download
M	src/cmd/godoc/main.go	View	1 2 3 4	3 chunks	+22 lines, -14 lines	0 comments	Download
M	src/cmd/godoc/zip.go	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org, adg@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-07-18 22:01:12 UTC) #1

gri

13 years, 4 months ago (2011-07-19 15:22:24 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=2e7ece227c7d ***

godoc: implement http.FileSystem for zip files

R=rsc, adg, bradfitz
CC=golang-dev
http://codereview.appspot.com/4750047

Expand All Messages | Collapse All Messages