Issue 4748053: Avoid dual-mode deferred (and immediate) export JS processor

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4748053: Avoid dual-mode deferred (and immediate) export JS processor

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by mhermanto

Modified:
14 years, 8 months ago

Reviewers:
johnfargo, fargo

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Each processor is concrete in what it does, ie: no more this.getXXXInstance(). Better for overidability.

Patch Set 1 : update #

Patch Set 2 : update #

Total comments: 1

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+294 lines, -59 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DeferredExportJsProcessor.java	View		1 chunk	+97 lines, -0 lines	1 comment	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/ExportJsProcessor.java	View	1	4 chunks	+4 lines, -33 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsServingPipelineModule.java	View		2 chunks	+2 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/DeferredExportJsProcessorTest.java	View		1 chunk	+190 lines, -0 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/ExportJsProcessorTest.java	View		1 chunk	+1 line, -25 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

johnfargo

14 years, 8 months ago (2011-07-18 22:04:06 UTC) #2

LGTM++

Thanks, this is much better.

http://codereview.appspot.com/4748053/diff/9001/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DeferredExportJsProcessor.java
(right):

http://codereview.appspot.com/4748053/diff/9001/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DeferredExportJsProcessor.java:63:
featureRegistry = featureRegistryProvider.get(jsUri.getRepository());
for later, we might consider adding this to JsRequest itself, since we now
precompute the requested/new/existing list there as well (it's a common
pattern).

Expand All Messages | Collapse All Messages