Issue 4742048: Fixes to AccessProtectedResources and subclasses

Issue 4742048: Fixes to AccessProtectedResources and subclasses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by yanivi

Modified:
14 years, 4 months ago

Reviewers:
moshenko

Visibility:
Public.

Patch Set 2 : rename to executeAccessTokenRequest() as requested #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -51 lines)			Patch
M	google-oauth-client-extensions/src/main/java/com/google/api/client/extensions/auth/helpers/appengine/AccessAppResource.java	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	google-oauth-client-extensions/src/main/java/com/google/api/client/extensions/auth/helpers/appengine/AppAssertionCredential.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	google-oauth-client-extensions/src/main/java/com/google/api/client/extensions/auth/helpers/oauth/OAuthHmacCredential.java	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	google-oauth-client-extensions/src/main/java/com/google/api/client/extensions/auth/helpers/oauth2/draft10/OAuth2Credential.java	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/draft10/AccessProtectedResource.java	View	1	2 chunks	+36 lines, -14 lines	0 comments	Download
M	google-oauth-client/src/test/java/com/google/api/client/auth/oauth2/draft10/AccessProtectedResourceTest.java	View		7 chunks	+92 lines, -25 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

moshenko

http://codereview.appspot.com/4742048/diff/1/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/draft10/AccessProtectedResource.java File google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/draft10/AccessProtectedResource.java (right): http://codereview.appspot.com/4742048/diff/1/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/draft10/AccessProtectedResource.java#newcode410 google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/draft10/AccessProtectedResource.java:410: protected final boolean setAccessToken(AccessTokenRequest request) throws IOException { Can ...

14 years, 4 months ago (2011-07-19 13:26:58 UTC) #2

yanivi

14 years, 4 months ago (2011-07-25 20:40:25 UTC) #3

moshenko

14 years, 4 months ago (2011-07-26 13:38:57 UTC) #4

On 2011/07/25 20:40:25, yanivi wrote:
>
http://codereview.appspot.com/4742048/diff/1/google-oauth-client/src/main/jav...
> File
>
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/draft10/AccessProtectedResource.java
> (right):
> 
>
http://codereview.appspot.com/4742048/diff/1/google-oauth-client/src/main/jav...
>
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/draft10/AccessProtectedResource.java:410:
> protected final boolean setAccessToken(AccessTokenRequest request) throws
> IOException {
> On 2011/07/19 13:27:00, moshenko wrote:
> > Can we rename this executeAccessTokenRequest()?  This would clear up most of
> my
> > initial confusion about why we had two overridable setAccessToken methods
with
> > different signatures.
> 
> Done.

LGTM

Expand All Messages | Collapse All Messages