Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(238)

Issue 4711043: Make test harness useable outside of Syzygy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by chrisha
Modified:
6 years, 3 months ago
Reviewers:
Roger McFarlane
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make test harness useable outside of Syzygy This makes the inputs to the test harness configurable rather than hardcoded. This allows the test harness to be used from other project directories. Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk383

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M syzygy/py/test_utils/gyp_tests.py View 1 2 5 chunks +27 lines, -3 lines 0 comments Download
M syzygy/py/test_utils/testing.py View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M syzygy/run_all_tests.bat View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
chrisha
PTAL
6 years, 3 months ago (2011-07-13 14:20:20 UTC) #1
Roger McFarlane
http://codereview.appspot.com/4711043/diff/2001/syzygy/py/test_utils/gyp_tests.py File syzygy/py/test_utils/gyp_tests.py (right): http://codereview.appspot.com/4711043/diff/2001/syzygy/py/test_utils/gyp_tests.py#newcode58 syzygy/py/test_utils/gyp_tests.py:58: if gyp_path: this moves the call to the parent's ...
6 years, 3 months ago (2011-07-13 15:02:49 UTC) #2
chrisha
PTAnotherL http://codereview.appspot.com/4711043/diff/2001/syzygy/py/test_utils/gyp_tests.py File syzygy/py/test_utils/gyp_tests.py (right): http://codereview.appspot.com/4711043/diff/2001/syzygy/py/test_utils/gyp_tests.py#newcode58 syzygy/py/test_utils/gyp_tests.py:58: if gyp_path: On 2011/07/13 15:02:49, Roger McFarlane wrote: ...
6 years, 3 months ago (2011-07-13 15:32:52 UTC) #3
Roger McFarlane
lgtm with nits http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_tests.py File syzygy/py/test_utils/gyp_tests.py (right): http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_tests.py#newcode64 syzygy/py/test_utils/gyp_tests.py:64: options, args = parser.parse_args() options, _args ...
6 years, 3 months ago (2011-07-13 15:39:22 UTC) #4
chrisha
6 years, 3 months ago (2011-07-13 15:51:23 UTC) #5
Thanks, committing.

http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_test...
File syzygy/py/test_utils/gyp_tests.py (right):

http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_test...
syzygy/py/test_utils/gyp_tests.py:64: options, args = parser.parse_args()
On 2011/07/13 15:39:22, Roger McFarlane wrote:
> options, _args = ...
> 
> -- or --
> 
> options, unused_args = ...
> 
> -- or --
> 
> options = parser.parse_args()[0]

Done.

http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_test...
syzygy/py/test_utils/gyp_tests.py:84: def _GetOptParser(self):
On 2011/07/13 15:39:22, Roger McFarlane wrote:
> Can this be static (here and in the parent class?)
> 
> With a note that it's may be referenced from the constructor before the parent
> class is fully constructed.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted