Issue 4709042: code review 4709042: gc: fix closure bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4709042: code review 4709042: gc: fix closure bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by lvd

Modified:
12 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gc: fix closure bug Fixes issue 2056.

Patch Set 1 #

Patch Set 2 : diff -r 207a10acbc0f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 207a10acbc0f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 207a10acbc0f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 207a10acbc0f https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r fa6814569009 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -38 lines)			Patch
M	src/cmd/gc/closure.c	View	1 2 3	6 chunks	+40 lines, -36 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
A	test/fixedbugs/bug346.go	View	1 2 3 4	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

LGTM please rename test please change CL desc to gc: fix closure bug Fixes issue ...

12 years, 9 months ago (2011-07-13 23:00:43 UTC) #2

lvd

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2011-07-14 16:13:37 UTC) #3

lvd

12 years, 9 months ago (2011-07-14 16:13:43 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=d30305e2898a ***

gc: fix closure bug

Fixes issue 2056.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4709042

Expand All Messages | Collapse All Messages