Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1865)

Issue 4709042: code review 4709042: gc: fix closure bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by lvd
Modified:
9 years, 7 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

gc: fix closure bug Fixes issue 2056.

Patch Set 1 #

Patch Set 2 : diff -r 207a10acbc0f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 207a10acbc0f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 207a10acbc0f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 207a10acbc0f https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r fa6814569009 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -38 lines) Patch
M src/cmd/gc/closure.c View 1 2 3 6 chunks +40 lines, -36 lines 0 comments Download
M src/cmd/gc/walk.c View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A test/fixedbugs/bug346.go View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4
lvd
but may'be it's not really better. please take a look.
9 years, 7 months ago (2011-07-13 05:40:04 UTC) #1
rsc
LGTM please rename test please change CL desc to gc: fix closure bug Fixes issue ...
9 years, 7 months ago (2011-07-13 23:00:43 UTC) #2
lvd
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 7 months ago (2011-07-14 16:13:37 UTC) #3
lvd
9 years, 7 months ago (2011-07-14 16:13:43 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=d30305e2898a ***

gc: fix closure bug

Fixes issue 2056.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4709042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b