Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(282)

Issue 4708042: code review 4708042: [release-branch.r58] cgo: handle new Apple LLVM-based g... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by rsc
Modified:
8 years, 4 months ago
Reviewers:
adg
CC:
golang-dev
Visibility:
Public.

Description

[release-branch.r58] cgo: handle new Apple LLVM-based gcc from Xcode 4.2 ««« CL 4607045 / 142f0bc0d6e7 cgo: handle new Apple LLVM-based gcc from Xcode 4.2 That gcc does not include enumerator names and values in its DWARF debug output. Create a data block from which we can read the values instead. Fixes issue 1881. R=iant CC=golang-dev http://codereview.appspot.com/4607045 »»»

Patch Set 1 #

Patch Set 2 : diff -r 4daf1e36d3c9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -19 lines) Patch
M src/cmd/cgo/gcc.go View 1 5 chunks +72 lines, -17 lines 0 comments Download
M src/pkg/debug/dwarf/type.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/debug/elf/file.go View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
8 years, 4 months ago (2011-07-12 14:19:09 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=d292bc788668 *** [release-branch.r58] cgo: handle new Apple LLVM-based gcc from Xcode 4.2 ...
8 years, 4 months ago (2011-07-12 14:19:15 UTC) #2
adg
8 years, 4 months ago (2011-07-13 04:44:02 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b