code review 4686049: codereview: fix for Mercurial 1.9

codereview: fix for Mercurial 1.9

[adg, 2011-07-12 00:42:44]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-07-12 00:43:46]

Tested this against hg 1.4.3. If anyone would care to test it on 1.8.x
that would be great.

[aam, 2011-07-12 01:04:11]

works for me:

$ hg diff | sed 3q
diff -r 80756338ccf7 lib/codereview/codereview.py
--- a/lib/codereview/codereview.py	Mon Jul 11 20:02:32 2011 -0400
+++ b/lib/codereview/codereview.py	Mon Jul 11 18:59:40 2011 -0600
$ hg sync
no changes found
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg clpatch 4662091
4662091:
	http: support for periodic flushing in ReverseProxy
[...]
$ hg --version
Mercurial Distributed SCM (version 1.8.2)

with the previous code every hg command failed under 1.9, i assume the
cursory check above to be sufficient. let me know if you want a
specific command tested.

[mikio, 2011-07-12 01:11:04]

LGTM, just confirmed that it works well w/ Mercurial 1.8.2.

Would you mind removing tab-char on L837 and 
unnecessary linebreak on L838?

http://codereview.appspot.com/4686049/diff/5001/lib/codereview/codereview.py
File lib/codereview/codereview.py (right):

http://codereview.appspot.com/4686049/diff/5001/lib/codereview/codereview.py#...
lib/codereview/codereview.py:84: 
a single linebreak is enough.

[adg, 2011-07-12 01:13:57]

Thanks for the tests, folks.

On 12 July 2011 11:11,  <mikioh.mikioh@gmail.com> wrote:
> LGTM, just confirmed that it works well w/ Mercurial 1.8.2.
>
> Would you mind removing tab-char on L837 and
> unnecessary linebreak on L838?

Sure, why not.

[rsc, 2011-07-12 02:58:44]

*** Submitted as http://code.google.com/p/go/source/detail?r=93ec1331584e ***

codereview: fix for Mercurial 1.9

R=golang-dev, mirtchovski, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/4686049

Committer: Russ Cox <rsc@golang.org>

[rsc, 2011-07-12 02:59:08]

looks like it works for me  :-)

On Mon, Jul 11, 2011 at 19:58,  <rsc@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=93ec1331584e ***
>
> codereview: fix for Mercurial 1.9
>
> R=golang-dev, mirtchovski, mikioh.mikioh
> CC=golang-dev
> http://codereview.appspot.com/4686049
>
> Committer: Russ Cox <rsc@golang.org>
>
>
> http://codereview.appspot.com/4686049/
>