Issue 4678045: code review 4678045: image/draw: add draw tests where the destination image ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4678045: code review 4678045: image/draw: add draw tests where the destination image ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by nigeltao

Modified:
13 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

image/draw: add draw tests where the destination image doesn't start at (0, 0). Also refactor the test to use the SubImage method rather than monkeying with an image's Pix and Rect fields.

Patch Set 1 #

Patch Set 2 : diff -r f45a563c817e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f45a563c817e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8c5c270c9653 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -48 lines)			Patch
	M	src/pkg/image/draw/draw_test.go	View	1	3 chunks	+64 lines, -48 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-07 09:35:30 UTC) #1

nigeltao

13 years, 8 months ago (2011-07-07 23:54:28 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6998f26de587 ***

image/draw: add draw tests where the destination image doesn't start
at (0, 0).

Also refactor the test to use the SubImage method rather than monkeying
with an image's Pix and Rect fields.

R=r
CC=golang-dev
http://codereview.appspot.com/4678045

Expand All Messages | Collapse All Messages