code review 4675081: cgi: close stdout reader pipe when finished

src/pkg/http/cgi/host.go

 // Copyright 2011 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // This file implements the host side of CGI (being the webserver
 // parent process).
 
 // Package cgi implements CGI (Common Gateway Interface) as specified
 // in RFC 3875.
 //
@@ skipping 169 matching lines @@
                 internalError(err)
                 return
         }
 
         err = cmd.Start()
         if err != nil {
                 internalError(err)
                 return
         }
         defer cmd.Wait()
+        defer stdoutRead.Close()
 
         linebody, _ := bufio.NewReaderSize(stdoutRead, 1024)
         headers := make(http.Header)
         statusCode := 0
         for {
                 line, isPrefix, err := linebody.ReadLine()
                 if isPrefix {
                         rw.WriteHeader(http.StatusInternalServerError)
                         h.printf("cgi: long header line from subprocess.")
                         return
@@ skipping 56 matching lines @@
                 for _, v := range vv {
                         rw.Header().Add(k, v)
                 }
         }
 
         rw.WriteHeader(statusCode)
 
         _, err = io.Copy(rw, linebody)
         if err != nil {
                 h.printf("cgi: copy error: %v", err)
-                cmd.Process.Kill()
         }
 }
 
 func (h *Handler) printf(format string, v ...interface{}) {
         if h.Logger != nil {
                 h.Logger.Printf(format, v...)
         } else {
                 log.Printf(format, v...)
         }
 }
@@ skipping 37 matching lines @@
                 return '_'
         case rune == '=':
                 // Maybe not part of the CGI 'spec' but would mess up
                 // the environment in any case, as Go represents the
                 // environment as a slice of "key=value" strings.
                 return '_'
         }
         // TODO: other transformations in spec or practice?
         return rune
 }