code review 4675063: cgi: don't depend on CGI.pm for tests

cgi: don't depend on CGI.pm for tests

CGI.pm used to be part of the Perl core,
but some distros now bundle perl-core
and perl-modules separately.

It's not worth depending on.

[bradfitz, 2011-07-07 20:44:25]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mattn, 2011-07-08 00:12:23]

http://codereview.appspot.com/4675063/diff/1002/src/pkg/http/cgi/testdata/tes...
File src/pkg/http/cgi/testdata/test.cgi (left):

http://codereview.appspot.com/4675063/diff/1002/src/pkg/http/cgi/testdata/tes...
src/pkg/http/cgi/testdata/test.cgi:12: my $q = CGI->new;
I guess this is better.

my $q = eval {
  require CGI;
  CGI->new;
} or MiniCGI->new;

[bradfitz, 2011-07-08 00:18:34]

On Thu, Jul 7, 2011 at 5:12 PM, <mattn.jp@gmail.com> wrote:

>
> http://codereview.appspot.com/**4675063/diff/1002/src/pkg/**
>
http/cgi/testdata/test.cgi<http://codereview.appspot.com/4675063/diff/1002/src/pkg/http/cgi/testdata/test.cgi>
> File src/pkg/http/cgi/testdata/**test.cgi (left):
>
> http://codereview.appspot.com/**4675063/diff/1002/src/pkg/**
>
http/cgi/testdata/test.cgi#**oldcode12<http://codereview.appspot.com/4675063/diff/1002/src/pkg/http/cgi/testdata/test.cgi#oldcode12>
> src/pkg/http/cgi/testdata/**test.cgi:12: my $q = CGI->new;
> I guess this is better.
>
> my $q = eval {
>  require CGI;
>  CGI->new;
> } or MiniCGI->new;
>

I'd like to minimize surprises.  One implementation in use simplifies
things.  It might be incomplete, but it's incomplete in the same ways
everywhere.

[mattn, 2011-07-08 00:28:53]

test passed on windows.

LGTM

On 2011/07/08 00:18:34, bradfitz wrote:
> On Thu, Jul 7, 2011 at 5:12 PM, <mailto:mattn.jp@gmail.com> wrote:
> 
> >
> > http://codereview.appspot.com/**4675063/diff/1002/src/pkg/**
> >
>
http/cgi/testdata/test.cgi<http://codereview.appspot.com/4675063/diff/1002/src/pkg/http/cgi/testdata/test.cgi>
> > File src/pkg/http/cgi/testdata/**test.cgi (left):
> >
> > http://codereview.appspot.com/**4675063/diff/1002/src/pkg/**
> >
>
http/cgi/testdata/test.cgi#**oldcode12<http://codereview.appspot.com/4675063/diff/1002/src/pkg/http/cgi/testdata/test.cgi#oldcode12>
> > src/pkg/http/cgi/testdata/**test.cgi:12: my $q = CGI->new;
> > I guess this is better.
> >
> > my $q = eval {
> >  require CGI;
> >  CGI->new;
> > } or MiniCGI->new;
> >
> 
> I'd like to minimize surprises.  One implementation in use simplifies
> things.  It might be incomplete, but it's incomplete in the same ways
> everywhere.

[bradfitz, 2011-07-08 00:45:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=d912d3d2954b ***

cgi: don't depend on CGI.pm for tests

CGI.pm used to be part of the Perl core,
but some distros now bundle perl-core
and perl-modules separately.

It's not worth depending on.

R=golang-dev, mattn.jp
CC=golang-dev
http://codereview.appspot.com/4675063