code review 4675047: godoc: ignore directories that begin with '.'

godoc: ignore directories that begin with '.'

Fixes issue 2017.

[adg, 2011-07-05 06:49:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-05 06:52:24]

http://codereview.appspot.com/4675047/diff/1/src/cmd/godoc/dirtrees.go
File src/cmd/godoc/dirtrees.go (right):

http://codereview.appspot.com/4675047/diff/1/src/cmd/godoc/dirtrees.go#newcode47
src/cmd/godoc/dirtrees.go:47: len(name) > 0 && name[0] != '_' && name[0] != '.'
comment the _ thingy
why not check for leading '.'

[adg, 2011-07-05 06:55:10]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-07-05 06:55:32]

On 5 July 2011 16:52,  <r@golang.org> wrote:
>
http://codereview.appspot.com/4675047/diff/1/src/cmd/godoc/dirtrees.go#newcode47
> src/cmd/godoc/dirtrees.go:47: len(name) > 0 && name[0] != '_' && name[0]
> != '.'
> comment the _ thingy

Done.

> why not check for leading '.'

eh? It does.

[r, 2011-07-05 06:57:41]

LGTM

[adg, 2011-07-05 07:00:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=c2e791394671 ***

godoc: ignore directories that begin with '.'

Fixes issue 2017.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4675047

[rsc, 2011-07-11 06:34:15]

removing the use of strings.HasPrefix seems gratuitous
and makes the logic harder to follow.  hard to believe
the performance matters here.

[adg, 2011-07-11 06:37:12]

On 11 July 2011 16:34, Russ Cox <rsc@golang.org> wrote:
> removing the use of strings.HasPrefix seems gratuitous
> and makes the logic harder to follow.  hard to believe
> the performance matters here.

Probably, but isPkgDir didn't use HasPrefix, so I just made isGoFile
do the same.

Andrew