code review 4673042: exp/template: add template sets, allowing templates to ...

exp/template: add template sets, allowing templates to reference one another

[r, 2011-07-04 01:51:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-07-04 04:44:35]

LGTM

http://codereview.appspot.com/4673042/diff/1/src/pkg/exp/template/exec.go
File src/pkg/exp/template/exec.go (right):

http://codereview.appspot.com/4673042/diff/1/src/pkg/exp/template/exec.go#new...
src/pkg/exp/template/exec.go:88: // walkIfOrWith walks an if or with node.
They're identical in behavior except that with sets dot.
break this comment over two lines.
"They're" is ambiguous here, consider rephrasing.

http://codereview.appspot.com/4673042/diff/1/src/pkg/exp/template/exec.go#new...
src/pkg/exp/template/exec.go:157: newState := *s
very cute

http://codereview.appspot.com/4673042/diff/1/src/pkg/exp/template/set.go
File src/pkg/exp/template/set.go (right):

http://codereview.appspot.com/4673042/diff/1/src/pkg/exp/template/set.go#newc...
src/pkg/exp/template/set.go:41: func (s *Set) Parse(text string) (err os.Error)
{
Are you going to add something like

func (s *Set) Add(name string, t *Template)

at some point?

[r, 2011-07-04 05:15:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=ffc556da636f ***

exp/template: add template sets, allowing templates to reference one another

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4673042