Issue 4670045: code review 4670045: exp/template: add templates to sets; boolean logic.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4670045: code review 4670045: exp/template: add templates to sets; boolean logic. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by r

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

exp/template: add templates to sets; boolean logic.

Patch Set 1 #

Patch Set 2 : diff -r af62813fadb2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r af62813fadb2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r af62813fadb2 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c2e791394671 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -14 lines)			Patch
M	src/pkg/exp/template/exec.go	View		2 chunks	+19 lines, -10 lines	0 comments	Download
M	src/pkg/exp/template/exec_test.go	View	1 2	2 chunks	+10 lines, -3 lines	0 comments	Download
M	src/pkg/exp/template/funcs.go	View	1 2 3 4	2 chunks	+30 lines, -1 line	0 comments	Download
M	src/pkg/exp/template/set.go	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-05 06:49:42 UTC) #1

dsymonds

Can you add a little test case to combine 'if' with 'and' and/or 'not'? Dave.

13 years, 8 months ago (2011-07-05 06:55:57 UTC) #2

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 8 months ago (2011-07-05 07:00:04 UTC) #3

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 8 months ago (2011-07-05 07:03:13 UTC) #5

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 8 months ago (2011-07-05 07:03:25 UTC) #6

13 years, 8 months ago (2011-07-05 07:05:21 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=bb79fe092dda ***

exp/template: add templates to sets; boolean logic.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4670045

Expand All Messages | Collapse All Messages