Use ibus_config_get_values () to improve performance.

Use ibus_config_get_values () to improve performance.


BUG=http://crosbug.com/16287
TEST=Linux desktop

[Yusuke Sato, 2011-07-05 05:31:44]

http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc
File src/PYConfig.cc (right):

http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc#newcode163
src/PYConfig.cc:163: ibus_config_get_values (get<IBusConfig> (), m_section.c_str
());
to prevent null ptr deref, please check the return value of the
ibus_config_get_values function.

http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc#newcode275
src/PYConfig.cc:275: normalizeGVariant (GVariant *value, const gchar * defval)
overloading functions with bool, gint and const gchar* looks scary to me (e.g.
which function will actually be called by normalizeGVariant(v, 0)?).

how about changing the last one to const std::string& ?

http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc#newcode308
src/PYConfig.cc:308: if (normalizeGVariant (value, TRUE))
question: is the correct function (i.e. the first one) called? I guess not...

[Peng, 2011-07-05 15:00:08]

http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc
File src/PYConfig.cc (right):

http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc#newcode163
src/PYConfig.cc:163: ibus_config_get_values (get<IBusConfig> (), m_section.c_str
());
On 2011/07/05 05:31:44, Yusuke Sato wrote:
> to prevent null ptr deref, please check the return value of the
> ibus_config_get_values function.

Done.

http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc#newcode275
src/PYConfig.cc:275: normalizeGVariant (GVariant *value, const gchar * defval)
On 2011/07/05 05:31:44, Yusuke Sato wrote:
> overloading functions with bool, gint and const gchar* looks scary to me (e.g.
> which function will actually be called by normalizeGVariant(v, 0)?).
> 
> how about changing the last one to const std::string& ?

Done.

http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc#newcode308
src/PYConfig.cc:308: if (normalizeGVariant (value, TRUE))
On 2011/07/05 05:31:44, Yusuke Sato wrote:
> question: is the correct function (i.e. the first one) called? I guess not...

Done.

[Yusuke Sato, 2011-07-05 15:38:04]

On 2011/07/05 15:00:08, Peng wrote:
> http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc
> File src/PYConfig.cc (right):
> 
> http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc#newcode163
> src/PYConfig.cc:163: ibus_config_get_values (get<IBusConfig> (),
m_section.c_str
> ());
> On 2011/07/05 05:31:44, Yusuke Sato wrote:
> > to prevent null ptr deref, please check the return value of the
> > ibus_config_get_values function.
> 
> Done.
> 
> http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc#newcode275
> src/PYConfig.cc:275: normalizeGVariant (GVariant *value, const gchar * defval)
> On 2011/07/05 05:31:44, Yusuke Sato wrote:
> > overloading functions with bool, gint and const gchar* looks scary to me
(e.g.
> > which function will actually be called by normalizeGVariant(v, 0)?).
> > 
> > how about changing the last one to const std::string& ?
> 
> Done.
> 
> http://codereview.appspot.com/4670044/diff/1/src/PYConfig.cc#newcode308
> src/PYConfig.cc:308: if (normalizeGVariant (value, TRUE))
> On 2011/07/05 05:31:44, Yusuke Sato wrote:
> > question: is the correct function (i.e. the first one) called? I guess
not...
> 
> Done.


lgtm