code review 4668054: exp/template: fixes and updates.

exp/template: fixes and updates.
- fix line numbers - forgot to update state.line during execution
- add a comment convention {{/* comment */}}
- set.Template returns the named template in the set
- set.Execute executes the named template in the set
- use a local methodByName so this package can be used with earlier release of reflect.
- use initial cap to detect exported names

[r, 2011-07-06 04:25:01]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-07-06 04:38:20]

LGTM modulo these comments

http://codereview.appspot.com/4668054/diff/1/src/pkg/exp/template/exec.go
File src/pkg/exp/template/exec.go (right):

http://codereview.appspot.com/4668054/diff/1/src/pkg/exp/template/exec.go#new...
src/pkg/exp/template/exec.go:256: /* Previous test - why is this wrong? Kept
here for reference.
change this to a // comment I guess

http://codereview.appspot.com/4668054/diff/1/src/pkg/exp/template/exec.go#new...
src/pkg/exp/template/exec.go:296: // TODO: delete when reflect's own
MethodByName is released.
I guess we can check this in, even though it's already available in this tree.

http://codereview.appspot.com/4668054/diff/1/src/pkg/exp/template/set.go
File src/pkg/exp/template/set.go (right):

http://codereview.appspot.com/4668054/diff/1/src/pkg/exp/template/set.go#newc...
src/pkg/exp/template/set.go:60: // the specified data object, writing the output
to wr.  Nested template
This first sentence is hard to parse.

http://codereview.appspot.com/4668054/diff/1/src/pkg/exp/template/set.go#newc...
src/pkg/exp/template/set.go:63: return s.tmpl[name].ExecuteInSet(wr, data, s)
Should this check that the template exists in the set?

[r, 2011-07-06 04:46:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=bae6efd2a58a ***

exp/template: fixes and updates.
- fix line numbers - forgot to update state.line during execution
- add a comment convention {{/* comment */}}
- set.Template returns the named template in the set
- set.Execute executes the named template in the set
- use a local methodByName so this package can be used with earlier release of
reflect.
- use initial cap to detect exported names

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4668054