[PDF] Update PDF shader code in the same way as r1684.

[PDF] Update PDF shader code in the same way as r1684.

[Steve VanDeBogart, 2011-06-25 01:31:01]

Mike, how did you test your change in 1684?  Will setting both radii in
gm/gradients.cpp trigger the condition?  I could slog through the math again,
but if you remember....

[reed1, 2011-06-27 13:14:48]

Perhaps we can keep the check for a the samein both cases: either both test a ==
0 or both tests a != 0, just to make it easier to see that its really 2
different equations (quad and linear), but with common code in the middle.

2. Try using string.appendf("%d %d roll min max etc");

This will allow you to put more of the logic in a single line, making it easier
to follow sometimes.

[Steve VanDeBogart, 2011-06-27 17:37:53]

On 2011/06/27 13:14:48, reed1 wrote:
> Perhaps we can keep the check for a the samein both cases: either both test a
==
> 0 or both tests a != 0, just to make it easier to see that its really 2

Done.

> different equations (quad and linear), but with common code in the middle.
> 
> 2. Try using string.appendf("%d %d roll min max etc");
> 
> This will allow you to put more of the logic in a single line, making it
easier
> to follow sometimes.

Done.

I just have have to figure out a test...

[reed1, 2011-06-27 17:41:21]

I'll submit a test soon (need it for the gpu case as well)

On Mon, Jun 27, 2011 at 1:37 PM,  <vandebo@chromium.org> wrote:
> On 2011/06/27 13:14:48, reed1 wrote:
>>
>> Perhaps we can keep the check for a the samein both cases: either both
>
> test a ==
>>
>> 0 or both tests a != 0, just to make it easier to see that its really
>
> 2
>
> Done.
>
>> different equations (quad and linear), but with common code in the
>
> middle.
>
>> 2. Try using string.appendf("%d %d roll min max etc");
>
>> This will allow you to put more of the logic in a single line, making
>
> it easier
>>
>> to follow sometimes.
>
> Done.
>
> I just have have to figure out a test...
>
> http://codereview.appspot.com/4662054/
>

[reed1, 2011-06-27 18:12:05]

gm/gradients.cpp has been updated with gradients_degenerate_2pt

On Mon, Jun 27, 2011 at 1:40 PM, Mike Reed <reed@google.com> wrote:
> I'll submit a test soon (need it for the gpu case as well)
>
> On Mon, Jun 27, 2011 at 1:37 PM,  <vandebo@chromium.org> wrote:
>> On 2011/06/27 13:14:48, reed1 wrote:
>>>
>>> Perhaps we can keep the check for a the samein both cases: either both
>>
>> test a ==
>>>
>>> 0 or both tests a != 0, just to make it easier to see that its really
>>
>> 2
>>
>> Done.
>>
>>> different equations (quad and linear), but with common code in the
>>
>> middle.
>>
>>> 2. Try using string.appendf("%d %d roll min max etc");
>>
>>> This will allow you to put more of the logic in a single line, making
>>
>> it easier
>>>
>>> to follow sometimes.
>>
>> Done.
>>
>> I just have have to figure out a test...
>>
>> http://codereview.appspot.com/4662054/
>>
>

[Steve VanDeBogart, 2011-06-27 20:19:02]

On 2011/06/27 18:12:05, reed1 wrote:
> gm/gradients.cpp has been updated with gradients_degenerate_2pt

Thanks, that helps.  For some reason the PDF code has the colors backward and I
don't see why.  I have to come back to this later.