Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 4661047: code review 4661047: os: fixed PathListSeparator to ';' for windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by mattn
Modified:
10 years, 5 months ago
Reviewers:
CC:
golang-dev_google.com, brainman, golang-dev
Visibility:
Public.

Description

os: fixed PathListSeparator to ';' for windows. Fixes issue 1992.

Patch Set 1 #

Patch Set 2 : diff -r 5b8d744d0d63 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5b8d744d0d63 http://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/os/path_windows.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
mattn
Hello golang-dev@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/
10 years, 5 months ago (2011-06-24 04:13:26 UTC) #1
brainman
LGTM
10 years, 5 months ago (2011-06-24 04:46:49 UTC) #2
brainman
Please, change description to say "Fixes issue 1992." instead of "Fixed issue 1992", and I ...
10 years, 5 months ago (2011-06-24 04:52:49 UTC) #3
brainman
10 years, 5 months ago (2011-06-24 05:01:06 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=4fae10f46847 ***

os: fixed PathListSeparator to ';' for windows.
Fixed issue 1992

R=golang-dev, alex.brainman
CC=golang-dev
http://codereview.appspot.com/4661047

Committer: Alex Brainman <alex.brainman@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b