Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2086)

Issue 466042: code review 466042: godoc: support for multiple packages in a directory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by gri
Modified:
4 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

godoc: support for multiple packages in a directory
- smartly select the "right" package
- provide a list of other packages

Patch Set 1 #

Patch Set 2 : code review 466042: godoc: support for multiple packages in a directory #

Total comments: 2

Patch Set 3 : code review 466042: godoc: support for multiple packages in a directory #

Patch Set 4 : code review 466042: godoc: support for multiple packages in a directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -27 lines) Patch
M lib/godoc/package.html View 1 chunk +8 lines, -0 lines 0 comments Download
M lib/godoc/package.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 2 3 6 chunks +60 lines, -25 lines 0 comments Download
M src/cmd/godoc/main.go View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
4 years, 1 month ago #1
rsc
LGTM http://codereview.appspot.com/466042/diff/2001/1007 File src/cmd/godoc/godoc.go (right): http://codereview.appspot.com/466042/diff/2001/1007#newcode1153 src/cmd/godoc/godoc.go:1153: // If the dirname is "go" we might ...
4 years, 1 month ago #2
gri
4 years, 1 month ago #3
*** Submitted as http://code.google.com/p/go/source/detail?r=9109a00488eb ***

godoc: support for multiple packages in a directory
- smartly select the "right" package
- provide a list of other packages

R=rsc
CC=golang-dev
http://codereview.appspot.com/466042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5