Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(978)

Issue 4660041: Send "Disable" D-Bus signal to engine when it is unset. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by Daiki Ueno
Modified:
14 years, 8 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Send "Disable" D-Bus signal to engine when it is unset. As IBus does not destroy engines anymore, there is no way to allow an engine to detect the input context is taken over by another engine. This patch emits "Disable" signal so that the old engine can do proper cleanup (e.g. hiding dialog). BUG=none TEST=manually

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M bus/inputcontext.c View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
Daiki Ueno
I need this for ibus-gucharmap to hide charmap dialog when user switched to another engine: ...
14 years, 8 months ago (2011-06-22 02:44:13 UTC) #1
Peng
On 2011/06/22 02:44:13, Daiki Ueno wrote: > I need this for ibus-gucharmap to hide charmap ...
14 years, 8 months ago (2011-06-23 03:25:33 UTC) #2
Daiki Ueno
14 years, 8 months ago (2011-06-27 08:44:07 UTC) #3
On 2011/06/23 03:25:33, Peng wrote: 
> I think the engine should be destroyed when it is not used anymore.

OK, moving to https://codereview.appspot.com/4662043/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b