Issue 4657074: code review 4657074: os: fix build for Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4657074: code review 4657074: os: fix build for Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by fhs

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, brainman

Visibility:
Public.

Patch Set 2 : diff -r 67b160cd5fa4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 67b160cd5fa4 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r b5354b8beea1 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b5354b8beea1 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r b5354b8beea1 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -4 lines)			Patch
	M	src/pkg/os/file_plan9.go	View	1 2 3 4	1 chunk	+26 lines, -0 lines	0 comments	Download
	M	src/pkg/os/file_unix.go	View	1 2 3 4 5	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fhs

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-05 02:52:58 UTC) #1

brainman

LGTM http://codereview.appspot.com/4657074/diff/3001/src/pkg/os/file_plan9.go File src/pkg/os/file_plan9.go (right): http://codereview.appspot.com/4657074/diff/3001/src/pkg/os/file_plan9.go#newcode19 src/pkg/os/file_plan9.go:19: l sync.Mutex // used to implement windows pread/pwrite ...

13 years, 8 months ago (2011-07-05 05:11:42 UTC) #2

fhs

Hello golang-dev@googlegroups.com, alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 8 months ago (2011-07-05 05:26:34 UTC) #3

fhs

Hello golang-dev@googlegroups.com, alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 8 months ago (2011-07-05 05:27:47 UTC) #4

brainman

13 years, 8 months ago (2011-07-05 06:01:43 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=e6dd75cd81b4 ***

os: fix build for Plan 9

R=golang-dev, alex.brainman
CC=golang-dev
http://codereview.appspot.com/4657074

Committer: Alex Brainman <alex.brainman@gmail.com>

Expand All Messages | Collapse All Messages