Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Unified Diff: src/cmd/goinstall/main.go

Issue 4657071: code review 4657071: goinstall: only report successfully-installed packages ... (Closed)
Patch Set: diff -r ffc556da636f https://go.googlecode.com/hg/ Created 13 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/cmd/goinstall/download.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cmd/goinstall/main.go
===================================================================
--- a/src/cmd/goinstall/main.go
+++ b/src/cmd/goinstall/main.go
@@ -182,9 +182,10 @@
}
// Download remote packages if not found or forced with -u flag.
remote := isRemote(pkg)
+ dashReport := false
if remote && (err == build.ErrNotFound || (err == nil && *update)) {
printf("%s: download\n", pkg)
- err = download(pkg, tree.SrcDir())
+ dashReport, err = download(pkg, tree.SrcDir())
}
if err != nil {
errorf("%s: %v\n", pkg, err)
@@ -243,6 +244,9 @@
}
}
}
+ if dashReport {
+ maybeReportToDashboard(pkg)
+ }
if remote {
// mark package as installed in $GOROOT/goinstall.log
logPackage(pkg)
« no previous file with comments | « src/cmd/goinstall/download.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b