Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 4650069: code review 4650069: docs: fold the prog.sh scripting from makehtml into htm... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by r
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

docs: fold the prog.sh scripting from makehtml into htmlgen itself. This allows us to drop some crufty scripting and provides a firmer footing for building better tools for preparing documents with source code inside. Also eliminate line numbers from the examples and text.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r ffc556da636f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d1c765f26e3b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+727 lines, -681 lines) Patch
M doc/go_tutorial.html View 1 45 chunks +523 lines, -522 lines 0 comments Download
M doc/go_tutorial.txt View 1 28 chunks +52 lines, -56 lines 0 comments Download
M doc/htmlgen.go View 1 11 chunks +151 lines, -16 lines 0 comments Download
M doc/makehtml View 2 chunks +1 line, -15 lines 0 comments Download
R doc/prog.sh View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-07-04 05:41:13 UTC) #1
adg
LGTM http://codereview.appspot.com/4650069/diff/1/doc/go_tutorial.html File doc/go_tutorial.html (right): http://codereview.appspot.com/4650069/diff/1/doc/go_tutorial.html#newcode29 doc/go_tutorial.html:29: <pre><!-- !src progs/helloworld.go /package/ END I kinda prefer ...
13 years, 8 months ago (2011-07-04 05:55:53 UTC) #2
r
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 8 months ago (2011-07-04 06:08:28 UTC) #3
adg
LGTM
13 years, 8 months ago (2011-07-04 06:11:21 UTC) #4
r
13 years, 8 months ago (2011-07-04 06:15:24 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=67b160cd5fa4 ***

docs: fold the prog.sh scripting from makehtml into htmlgen itself.
This allows us to drop some crufty scripting and provides a firmer
footing for building better tools for preparing documents with source
code inside.

Also eliminate line numbers from the examples and text.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4650069
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b