code review 4645078: go/build: evaluate symlinks before comparing path to GOPATH

go/build: evaluate symlinks before comparing path to GOPATH

[adg, 2011-07-03 07:57:32]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-03 12:31:32]

LGTM

[dsymonds, 2011-07-03 13:51:45]

http://codereview.appspot.com/4645078/diff/1/src/pkg/go/build/path.go
File src/pkg/go/build/path.go (right):

http://codereview.appspot.com/4645078/diff/1/src/pkg/go/build/path.go#newcode91
src/pkg/go/build/path.go:91: if path, err = filepath.EvalSymlinks(path); err !=
nil {
This can replace the filepath.Abs call on line 88.

[adg, 2011-07-04 00:25:12]

On 3 July 2011 23:51,  <dsymonds@golang.org> wrote:
>
> http://codereview.appspot.com/4645078/diff/1/src/pkg/go/build/path.go
> File src/pkg/go/build/path.go (right):
>
>
http://codereview.appspot.com/4645078/diff/1/src/pkg/go/build/path.go#newcode91
> src/pkg/go/build/path.go:91: if path, err = filepath.EvalSymlinks(path);
> err != nil {
> This can replace the filepath.Abs call on line 88.

No, it can't. The user might run "goinstall .", and the dot would need
to be expanded to an absolute path first.

Andrew

[adg, 2011-07-04 00:26:14]

*** Submitted as http://code.google.com/p/go/source/detail?r=3b435848016e ***

go/build: evaluate symlinks before comparing path to GOPATH

R=golang-dev, r, dsymonds
CC=golang-dev
http://codereview.appspot.com/4645078