Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(493)

Issue 4645073: code review 4645073: os: use a different symbol from syscall in mkunixsignals.sh. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by dsymonds
Modified:
13 years, 8 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

os: use a different symbol from syscall in mkunixsignals.sh. Open is more likely to be present than Syscall.

Patch Set 1 #

Patch Set 2 : diff -r d86f80185297 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d86f80185297 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d86f80185297 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 916057d73e34 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/os/mkunixsignals.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
dsymonds
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-06-30 03:17:59 UTC) #1
rsc
LGTM
13 years, 8 months ago (2011-06-30 03:30:35 UTC) #2
rsc
Actually that doesn't work.
13 years, 8 months ago (2011-06-30 03:30:49 UTC) #3
rsc
On Wed, Jun 29, 2011 at 23:30, Russ Cox <rsc@golang.org> wrote: > Actually that doesn't ...
13 years, 8 months ago (2011-06-30 03:31:52 UTC) #4
dsymonds
On Thu, Jun 30, 2011 at 1:30 PM, Russ Cox <rsc@golang.org> wrote: > Actually that ...
13 years, 8 months ago (2011-06-30 03:31:56 UTC) #5
dsymonds
On Thu, Jun 30, 2011 at 1:31 PM, Russ Cox <rsc@golang.org> wrote: > Even better ...
13 years, 8 months ago (2011-06-30 03:33:27 UTC) #6
rsc
LGTM
13 years, 8 months ago (2011-06-30 03:34:27 UTC) #7
dsymonds
13 years, 8 months ago (2011-06-30 03:35:51 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=cb8e60c056aa ***

os: use a different symbol from syscall in mkunixsignals.sh.

Open is more likely to be present than Syscall.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4645073
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b