code review 4643072: exp/template: index function for arrays, slices, and maps.

exp/template: index function for arrays, slices, and maps.

[r, 2011-07-06 11:25:15]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-07-06 11:46:10]

LGTM

This will make some people very happy.

http://codereview.appspot.com/4643072/diff/1/src/pkg/exp/template/funcs.go
File src/pkg/exp/template/funcs.go (right):

http://codereview.appspot.com/4643072/diff/1/src/pkg/exp/template/funcs.go#ne...
src/pkg/exp/template/funcs.go:90: case reflect.Int8, reflect.Int16,
reflect.Int32, reflect.Int64:
What about reflect.Int? And reflect.Uint?

http://codereview.appspot.com/4643072/diff/1/src/pkg/exp/template/funcs.go#ne...
src/pkg/exp/template/funcs.go:93: x = int64(index.Uint())
I don't understand what int64 is doing here.

[r2, 2011-07-06 12:26:54]

On 06/07/2011, at 9:46 PM, adg@golang.org wrote:

> LGTM
> 
> This will make some people very happy.
> 
> 
> http://codereview.appspot.com/4643072/diff/1/src/pkg/exp/template/funcs.go
> File src/pkg/exp/template/funcs.go (right):
> 
>
http://codereview.appspot.com/4643072/diff/1/src/pkg/exp/template/funcs.go#ne...
> src/pkg/exp/template/funcs.go:90: case reflect.Int8, reflect.Int16,
> reflect.Int32, reflect.Int64:
> What about reflect.Int? And reflect.Uint?

added.

>
http://codereview.appspot.com/4643072/diff/1/src/pkg/exp/template/funcs.go#ne...
> src/pkg/exp/template/funcs.go:93: x = int64(index.Uint())
> I don't understand what int64 is doing here.

Len returns an int but x is int64.  if instead it was int(x) >= v.Len() then if
x was larger than int the test would fail incorrectly.

-rob

[r, 2011-07-06 12:27:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=743cfe1095ed ***

exp/template: index function for arrays, slices, and maps.

R=golang-dev, adg, r
CC=golang-dev
http://codereview.appspot.com/4643072

[fvb, 2011-07-06 13:34:05]

http://codereview.appspot.com/4643072/diff/6001/src/pkg/exp/template/funcs.go
File src/pkg/exp/template/funcs.go (right):

http://codereview.appspot.com/4643072/diff/6001/src/pkg/exp/template/funcs.go...
src/pkg/exp/template/funcs.go:92: case reflect.Uint, reflect.Uint8,
reflect.Uint16, reflect.Uint32, reflect.Uint64:
reflect.Uintptr?

[fvb, 2011-07-06 13:36:21]

On 2011/07/06 13:34:05, fvb wrote:
> reflect.Uintptr?

Never mind, just saw http://codereview.appspot.com/4636087/