Issue 4643071: code review 4643071: exp/template: silence test noise (but add a flag to put...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4643071: code review 4643071: exp/template: silence test noise (but add a flag to put... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by r

Modified:
13 years, 8 months ago

Reviewers:
r2

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

exp/template: silence test noise (but add a flag to put it back) Also delete a TODO and clean up a little evaluation code.

Patch Set 2 : diff -r 5820a7fadfd0 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
M	src/pkg/exp/template/exec.go	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/pkg/exp/template/parse_test.go	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/exp/template/set_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-06 07:23:02 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/4643071/diff/1/src/pkg/exp/template/parse_test.go File src/pkg/exp/template/parse_test.go (right): http://codereview.appspot.com/4643071/diff/1/src/pkg/exp/template/parse_test.go#newcode9 src/pkg/exp/template/parse_test.go:9: "flag" sort http://codereview.appspot.com/4643071/diff/1/src/pkg/exp/template/parse_test.go#newcode13 src/pkg/exp/template/parse_test.go:13: var dumpErrors = flag.Bool("errors", ...

13 years, 8 months ago (2011-07-06 07:37:56 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=889bb48b3b36 *** exp/template: silence test noise (but add a flag to put ...

13 years, 8 months ago (2011-07-06 07:46:42 UTC) #3

13 years, 8 months ago (2011-07-06 10:43:51 UTC) #4

Map indexing isn't implemented yet, but with functions you can do anything...

By the way, no need to use ExecuteInSet in your example, just use Execute.

-rob

Expand All Messages | Collapse All Messages