Issue 4643044: code review 4643044: weekly.2011-06-16

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4643044: code review 4643044: weekly.2011-06-16 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by adg

Modified:
14 years ago

Reviewers:
bsiegert

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

weekly.2011-06-16

Patch Set 1 #

Patch Set 2 : diff -r 20d3c7744959 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -1 line)			Patch
	M	.hgtags	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	doc/devel/weekly.html	View	1	1 chunk	+53 lines, -0 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-06-17 01:20:38 UTC) #1

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=dac76f0b1a18 *** weekly.2011-06-16 R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4643044

14 years ago (2011-06-17 01:31:49 UTC) #3

bsiegert

14 years ago (2011-06-22 08:49:55 UTC) #4

http://codereview.appspot.com/4643044/diff/1003/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/4643044/diff/1003/doc/devel/weekly.html#newcode61
doc/devel/weekly.html:61: unsafe.Alignof/Offsetof/Sizeof return uintptr.
Maybe this should be mentioned at the top, as it is likely to necessitate code
changes in code that uses unsafe.

Expand All Messages | Collapse All Messages