Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(601)

Issue 4643044: code review 4643044: weekly.2011-06-16 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by adg
Modified:
11 years, 5 months ago
Reviewers:
bsiegert
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

weekly.2011-06-16

Patch Set 1 #

Patch Set 2 : diff -r 20d3c7744959 https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 1 chunk +53 lines, -0 lines 1 comment Download

Messages

Total messages: 4
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 5 months ago (2011-06-17 01:20:38 UTC) #1
dsymonds
LGTM
11 years, 5 months ago (2011-06-17 01:22:40 UTC) #2
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=dac76f0b1a18 *** weekly.2011-06-16 R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4643044
11 years, 5 months ago (2011-06-17 01:31:49 UTC) #3
bsiegert
11 years, 5 months ago (2011-06-22 08:49:55 UTC) #4
http://codereview.appspot.com/4643044/diff/1003/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/4643044/diff/1003/doc/devel/weekly.html#newcode61
doc/devel/weekly.html:61: unsafe.Alignof/Offsetof/Sizeof return uintptr.
Maybe this should be mentioned at the top, as it is likely to necessitate code
changes in code that uses unsafe.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b