Builder pattern api for caja.js

Alternate calling pattern for caja.js which more clearly identifies
type of authority being passed to guest code.

Also adds several default network policies.

@4555

[Jasvir, 2011-07-01 15:44:28]

Not ready for review yet.

[Jasvir, 2011-07-07 00:01:55]

Snapshot with suggestion from Ihab to call makeES5Frame earlier.

[Jasvir, 2011-07-10 04:17:10]

Added remaining es53 tests.  Ready for review.

[ihab.awad, 2011-07-12 22:45:05]

http://codereview.appspot.com/4641070/diff/6001/tests/com/google/caja/plugin/...
File tests/com/google/caja/plugin/es53-test-cajajs-invocation.js (right):

http://codereview.appspot.com/4641070/diff/6001/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:142:
registerTest('testBuilderApiContent', function testBuilderApiContent() {
Minor nit: would calling it "testBuilderApiContentHtml" be more consistent?

http://codereview.appspot.com/4641070/diff/6001/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:171: function
testBuilderApiContentCajoled() {
...ContentCajoledHtml... ?

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
File src/com/google/caja/plugin/caja.js (right):

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:599: ONLY: function(url) {
Function name should be lowercase (camelCase, actually).

[Jasvir, 2011-07-12 23:27:17]

http://codereview.appspot.com/4641070/diff/6001/tests/com/google/caja/plugin/...
File tests/com/google/caja/plugin/es53-test-cajajs-invocation.js (right):

http://codereview.appspot.com/4641070/diff/6001/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:142:
registerTest('testBuilderApiContent', function testBuilderApiContent() {
On 2011/07/12 22:45:05, ihab.awad wrote:
> Minor nit: would calling it "testBuilderApiContentHtml" be more consistent?

Done.

http://codereview.appspot.com/4641070/diff/6001/tests/com/google/caja/plugin/...
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:171: function
testBuilderApiContentCajoled() {
On 2011/07/12 22:45:05, ihab.awad wrote:
> ...ContentCajoledHtml... ?

Done.

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
File src/com/google/caja/plugin/caja.js (right):

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:599: ONLY: function(url) {
On 2011/07/12 22:45:05, ihab.awad wrote:
> Function name should be lowercase (camelCase, actually).

Done.

[ihab.awad, 2011-07-12 23:49:46]

lgtm++

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
File src/com/google/caja/plugin/caja.js (right):

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:591: throw new Error("Method '" + name + "'
before caja is ready");
Perhaps "Called method ..." to be clear what we're kvetching about? ;) Also, it
would be nice to be consistent with using single quotes around strings in JS.

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:637: for (var i=0; i < callbacks_.length;
i++) {
Spaces around operators.

http://codereview.appspot.com/4641070/diff/21001/src/com/google/caja/plugin/c...
File src/com/google/caja/plugin/caja.js (right):

http://codereview.appspot.com/4641070/diff/21001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:667: // Configure with default defaults
Should we call it something other than "setDefaults" then? Like maybe
"initializeSettings" or "setup" or "setParams" or ... ${whatever} ... ?

http://codereview.appspot.com/4641070/diff/21001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:762: iframe: errorMaker('iframe')
Missing a public "whenReady" for the "caja" object.

[Jasvir, 2011-07-13 06:12:30]

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
File src/com/google/caja/plugin/caja.js (right):

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:591: throw new Error("Method '" + name + "'
before caja is ready");
On 2011/07/12 23:49:47, ihab.awad wrote:
> Perhaps "Called method ..." to be clear what we're kvetching about? ;) Also,
it
> would be nice to be consistent with using single quotes around strings in JS.

Done.

http://codereview.appspot.com/4641070/diff/14001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:637: for (var i=0; i < callbacks_.length;
i++) {
On 2011/07/12 23:49:47, ihab.awad wrote:
> Spaces around operators.

Done.

http://codereview.appspot.com/4641070/diff/21001/src/com/google/caja/plugin/c...
File src/com/google/caja/plugin/caja.js (right):

http://codereview.appspot.com/4641070/diff/21001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:667: // Configure with default defaults
Changed to initialize()

On 2011/07/12 23:49:47, ihab.awad wrote:
> Should we call it something other than "setDefaults" then? Like maybe
> "initializeSettings" or "setup" or "setParams" or ... ${whatever} ... ?

http://codereview.appspot.com/4641070/diff/21001/src/com/google/caja/plugin/c...
src/com/google/caja/plugin/caja.js:762: iframe: errorMaker('iframe')
On 2011/07/12 23:49:47, ihab.awad wrote:
> Missing a public "whenReady" for the "caja" object.

Done.