Issue 4639096: code review 4639096: exp/template: allow complex numbers, add 'with', 'defin...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4639096: code review 4639096: exp/template: allow complex numbers, add 'with', 'defin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by r

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

exp/template: allow complex numbers, add 'with', 'define', and 'template' keywords. Also simplify the handling of keywords.

Patch Set 2 : diff -r ba5a6e6631b1 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -32 lines)			Patch
	M	src/pkg/exp/template/lex.go	View	1	5 chunks	+58 lines, -30 lines	0 comments	Download
	M	src/pkg/exp/template/lex_test.go	View		3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-04 01:39:06 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/4639096/diff/1/src/pkg/exp/template/lex.go File src/pkg/exp/template/lex.go (right): http://codereview.appspot.com/4639096/diff/1/src/pkg/exp/template/lex.go#newcode60 src/pkg/exp/template/lex.go:60: itemKeyword = itemDot // lowest-valued keyword This is ...

13 years, 8 months ago (2011-07-04 01:45:00 UTC) #2

13 years, 8 months ago (2011-07-04 01:50:41 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=2e41f99f7370 ***

exp/template: allow complex numbers, add 'with', 'define', and 'template'
keywords.
Also simplify the handling of keywords.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4639096

Expand All Messages | Collapse All Messages