code review 4639091: lib9: stop build if ../version.bash fails

lib9: stop build if ../version.bash fails

[brainman, 2011-07-01 06:31:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[captn, 2011-07-01 08:10:21]

+1 hg sucks (just in the case someone changes his mind ;)

diff --git a/src/version.bash b/src/version.bash
index ce5a996..3ddff6c 100755
--- a/src/version.bash
+++ b/src/version.bash
@@ -12,8 +17,17 @@ fi
 # Get numerical revision
 VERSION=$(hg identify -n 2>/dev/null)
 if [ $? != 0 ]; then
-	OLD=$(hg identify | sed 1q)
+	OLD=$(hg identify 2>/dev/null | sed 1q)
 	VERSION=$(echo $OLD | awk '{print $1}')
+	if [ "$VERSION" == "" ]; then
+		VERSION="$(git describe --tags --match
'[wr]e[el][ke][la][ys][e.][2.][02r][0-9]*' 2>/dev/null)"
+		if [ "$VERSION" != "" ]; then
+			echo $VERSION
+		else
+			echo '?'
+		fi
+		exit 0
+	fi
 fi
 
 # Get branch type

[brainman, 2011-07-01 12:23:56]

On 2011/07/01 08:10:21, captn wrote:
> +1 hg sucks ...

I'm not suggesting to change version.bash in any way. I would like to stop build
if version.bash script fails.

If you want to change version.bash, please create new CL. Thank you.

Alex

[rsc, 2011-07-01 14:42:25]

LGTM

[rsc, 2011-07-01 14:42:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=a5a785546718 ***

lib9: stop build if ../version.bash fails

R=golang-dev, m, rsc
CC=golang-dev
http://codereview.appspot.com/4639091

Committer: Russ Cox <rsc@golang.org>

[rsc, 2011-07-01 14:43:40]

On Fri, Jul 1, 2011 at 08:23,  <alex.brainman@gmail.com> wrote:
> On 2011/07/01 08:10:21, captn wrote:
>>
>> +1 hg sucks ...
>
> I'm not suggesting to change version.bash in any way. I would like to
> stop build if version.bash script fails.
>
> If you want to change version.bash, please create new CL. Thank you.

Also, please don't create a new CL.
This has been suggested before.
The Go project is using Mercurial.  If you want to use Git
we're not going to stop you, but we're also not going to
maintain changes in our build process to adjust for
systems we're not using.

Russ