Issue 4636067: code review 4636067: html: fix nesting with close tag.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4636067: code review 4636067: html: fix nesting with close tag. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by mattn

Modified:
13 years, 8 months ago

Reviewers:
bradfitz

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

html: fix nesting with close tag. when arrive at close tag, it should go out from current node structure. currently, parser always make broken heavy nested structure.

Patch Set 1 #

Patch Set 2 : diff -r cb5ad47b6e02 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cb5ad47b6e02 http://go.googlecode.com/hg/ #

Patch Set 4 : diff -r cb5ad47b6e02 http://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/pkg/html/parse.go	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mattn

Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://go.googlecode.com/hg/

13 years, 8 months ago (2011-06-28 08:36:01 UTC) #1

nigeltao

LGTM. Yeah, the long term solution is to do what the HTML5 spec says, but ...

13 years, 8 months ago (2011-06-30 13:07:52 UTC) #3

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=8d3830d81510 *** html: fix nesting when parsing a close tag. R=nigeltao CC=golang-dev ...

13 years, 8 months ago (2011-06-30 13:18:34 UTC) #4

bradfitz

13 years, 8 months ago (2011-06-30 14:20:38 UTC) #5

A new test would've been nice.

On Thu, Jun 30, 2011 at 6:18 AM, <nigeltao@golang.org> wrote:

> *** Submitted as
>
http://code.google.com/p/go/**source/detail?r=8d3830d81510<http://code.google...
>
> html: fix nesting when parsing a close tag.
>
> R=nigeltao
> CC=golang-dev
>
> http://codereview.appspot.com/**4636067<http://codereview.appspot.com/4636067>
>
> Committer: Nigel Tao <nigeltao@golang.org>
>
>
>
>
http://codereview.appspot.com/**4636067/<http://codereview.appspot.com/4636067/>
>

Expand All Messages | Collapse All Messages