Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 4636044: code review 4636044: goinstall, go/build: support building cgo packages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by adg
Modified:
11 years, 7 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

goinstall, go/build: support building cgo packages Fixes issue 1962.

Patch Set 1 #

Patch Set 2 : diff -r 4795e1786223 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4795e1786223 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 12cc5b3cc379 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M src/cmd/goinstall/main.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/build/build.go View 1 2 9 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 11
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 7 months ago (2011-06-16 22:29:09 UTC) #1
bradfitz
LGTM On Thu, Jun 16, 2011 at 3:29 PM, <adg@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
11 years, 7 months ago (2011-06-16 22:31:59 UTC) #2
adg
Matt, could you please try this with go-gtk? I hope I haven't broken the pkg-config ...
11 years, 7 months ago (2011-06-16 22:35:45 UTC) #3
bradfitz
c:\\go\\foo/c:\\go\\foo --- something forgetting to use filepath? On Thu, Jun 16, 2011 at 5:00 PM, ...
11 years, 7 months ago (2011-06-17 00:04:36 UTC) #4
adg
On 17 June 2011 10:04, Brad Fitzpatrick <bradfitz@golang.org> wrote: > c:\\go\\foo/c:\\go\\foo --- something forgetting to ...
11 years, 7 months ago (2011-06-17 00:14:44 UTC) #5
adg
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 7 months ago (2011-06-17 00:18:12 UTC) #6
adg
Mattn, please sync to tip, clpatch this change, and try again. Thanks for your help! ...
11 years, 7 months ago (2011-06-17 00:19:00 UTC) #7
adg
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 7 months ago (2011-06-17 00:21:54 UTC) #8
adg
On 17 June 2011 10:45, mattn <mattn.jp@gmail.com> wrote: > Hmm, same above. Really? That doesn't ...
11 years, 7 months ago (2011-06-17 00:52:00 UTC) #9
adg
On 17 June 2011 11:02, mattn <mattn.jp@gmail.com> wrote: > I can't see the any output. ...
11 years, 7 months ago (2011-06-17 01:05:20 UTC) #10
adg
11 years, 7 months ago (2011-06-17 01:16:21 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=20d3c7744959 ***

goinstall, go/build: support building cgo packages

Fixes issue 1962.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4636044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b