Issue 4635049: Store capabilities when ibuscontext is not ready yet.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4635049: Store capabilities when ibuscontext is not ready yet. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by kinaba

Modified:
14 years, 8 months ago

Reviewers:
shawn.p.huang

Base URL:
git://github.com/phuang/ibus.git@master

Visibility:
Public.

Description

Store capabilities when ibuscontext is not ready yet. Due to the asynchronous creation of contexts, gtk_im_set_use_preedit may be called before the context is ready. This patch is to record the change of capability flag and enables to set it later in _create_input_context_done. BUG=http://crosbug.com/16500 TEST=ChromeOS Cr-48

Patch Set 1 #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	client/gtk2/ibusimcontext.c	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

On 2011/06/18 03:55:52, Peng wrote: > On 2011/06/17 07:42:32, kinaba wrote: > > LGTM. Thx ...

14 years, 8 months ago (2011-06-28 04:19:47 UTC) #3

kinaba

14 years, 8 months ago (2011-06-28 04:31:20 UTC) #4

On 2011/06/28 04:19:47, Peng wrote:
> On 2011/06/18 03:55:52, Peng wrote:
> > On 2011/06/17 07:42:32, kinaba wrote:
> > 
> > LGTM. Thx
> 
> I remember I submit it to ibus repo. Please close this CL. Thanks.

Thanks. Closed.

Expand All Messages | Collapse All Messages